Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): use center position of handle as snapping point for connection lines #1625

Merged
merged 10 commits into from
Jan 4, 2025
Merged

fix(core): use center position of handle as snapping point for connection lines #1625

merged 10 commits into from
Jan 4, 2025

Conversation

bcakmakoglu
Copy link
Owner

@bcakmakoglu bcakmakoglu commented Sep 17, 2024 •
edited
Loading

🚀 What's changed?

  • Calculate handle positions with centered position
  • Remove handleId check if handle has no id

🐛 Fixes

  • Handles not centered if stretched across a node

@bcakmakoglu bcakmakoglu added the bug Something isn't working label Sep 17, 2024
@bcakmakoglu bcakmakoglu self-assigned this Sep 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2162bac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-flow-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 0:52am

@bcakmakoglu bcakmakoglu marked this pull request as ready for review September 23, 2024 16:07
Base automatically changed from next-release to master November 1, 2024 18:48
@bcakmakoglu
fix(core): calculate handle positions correctly
977fe34 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
fix(core): remove handleId check
854dc81 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
chore(core): cleanup
26485f8 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
chore(core): cleanup click connect handlers
43a9712 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
fix(core): add flow id to handle ids
60a6f84 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
tests: correct updateEdge test
285a1a0 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
fix(core): use center position of handle
4e8c099 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu bcakmakoglu changed the title fix(core): calculate handle positions correctly fix(core): use center position of handle as snapping point Jan 3, 2025
@bcakmakoglu bcakmakoglu changed the title fix(core): use center position of handle as snapping point fix(core): use center position of handle as snapping point for connection lines and edges Jan 3, 2025
@bcakmakoglu bcakmakoglu changed the title fix(core): use center position of handle as snapping point for connection lines and edges fix(core): use center position of handle as snapping point for connection lines Jan 3, 2025
@bcakmakoglu
chore(examples): cleanup easy connect example
9434e94 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
refactor(tests): run actions on chrome
d8b2d72 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu
chore(workflows): correctly hash lock file
2162bac 
Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@bcakmakoglu bcakmakoglu changed the base branch from master to next-release January 4, 2025 12:54
@bcakmakoglu bcakmakoglu merged commit e147a0e into next-release Jan 4, 2025
4 checks passed
bcakmakoglu added a commit that referenced this pull request Jan 4, 2025
@bcakmakoglu
fix(core): use center position of handle as snapping point for connec…
b33da47 
…tion lines (#1625)

* fix(core): calculate handle positions correctly

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* fix(core): remove handleId check

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* chore(core): cleanup

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* chore(core): cleanup click connect handlers

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* fix(core): add flow id to handle ids

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* tests: correct updateEdge test

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* fix(core): use center position of handle

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* chore(examples): cleanup easy connect example

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* refactor(tests): run actions on chrome

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* chore(workflows): correctly hash lock file

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

---------

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
@BcakmakogluAI BcakmakogluAI deleted the fix/handle-pos branch January 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bcakmakoglu bcakmakoglu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcakmakoglu